Skip to content

xilinx: added xilinx 7 series architecture definitions and configurat… #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2025
Merged

xilinx: added xilinx 7 series architecture definitions and configurat… #22

merged 1 commit into from
Mar 15, 2025

Conversation

lromor
Copy link
Owner

@lromor lromor commented Mar 13, 2025

…ion packet

@lromor lromor requested a review from hzeller March 13, 2025 23:07
@lromor lromor force-pushed the feature-add-bitstream-writer branch from 6d5d9be to 72a93aa Compare March 13, 2025 23:09
@hzeller
Copy link
Collaborator

hzeller commented Mar 14, 2025

The code is coming from somewhere else, right ? Make sure to add a README at the toplevel of xilinx/ describing where it is coming from (URL), reasons for the copy (needs local modifications) and a LICENSE file in case it is different than the Apache (looks like it is ISC license, so it is different).

Use the @rules_license to point to the correct license in each BUILD file.

@lromor lromor force-pushed the feature-add-bitstream-writer branch 2 times, most recently from 0758503 to 407d9fc Compare March 14, 2025 17:57
hzeller
hzeller approved these changes Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you only have a license in the fpga/xilinx directory, which clarifies that license, but you want to also add the apache 2 license annotation in the fpga/ directory

@lromor lromor force-pushed the feature-add-bitstream-writer branch 9 times, most recently from e09f79e to 62507df Compare March 14, 2025 21:56
@lromor lromor force-pushed the feature-add-bitstream-writer branch from 62507df to 2a32286 Compare March 14, 2025 21:59
hzeller
hzeller reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@hzeller hzeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The license in the fpga/BUILD file pointing to Apache should still be added.

@lromor lromor merged commit 5a7eb34 into main Mar 15, 2025
4 checks passed
@lromor lromor deleted the feature-add-bitstream-writer branch March 15, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzeller hzeller hzeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lromor @hzeller